Hey Tom,
Reviewing this bot now. The fixup of the ro- bot looks fine, thank you, just dealing with some issues at this end on that one & we can get it up and running again.
So on to this Bosnia bot:
It looks as if some of the start dates on the licences are not identical, so setting the start date at the root level (ie for all permissions) isn't quite right I don't think. For example on this page http://www.komvp.gov.ba/site/index.php/en/investment-funds/depository-banks/299-sparcasse-d-d-sarajevo#license we have 2 start dates for different licences and are setting a start_date of: "start_date": "2005-12-01",
Is that a correct reading of the situation? If so I would actually suggest splitting these different licences off into separate records, specifically 1 record for each actual licence, possibly concatenating the general licence category so that they all make sense. So for this example instead of these 3 permissions:
{
"activity_name": "Depository and custody bank",
"permission_type": "operating"
},
{
"activity_name": "Depository Operations",
"permission_type": "operating"
},
{
"activity_name": "Custody Operations",
"permission_type": "operating"
}
I would split this into 2 distinct records, one of them having:
{
"activity_name": "Depository and custody bank - Custody Operations",
"permission_type": "operating"
}
and the other having:
{
"activity_name": "Depository and custody bank - Depository Operations",
"permission_type": "operating"
},
We could then of course also set the correct start_date for each licence at the root level. What do you think?
Otherwise it's looking great!
Thanks as always,
Peter