Hi Tom,
Thanks for pushing this again, have responded on Slack but will add the specific info here:
I'm looking at do-valores right now - this is looking really good - it's testing my knowledge of the licence schema though! I think shareholders should not be transformed as officers as they're to do with ownership rather than official representation. We have two options here for do-valores - if you have time we can make an edit to include the shareholders + their share parcels, if not we should just exclude them from the officers field (& we can add them in properly later)
the fix to include them as shareholders I believe is to switch the entity type from "unknown_entity_type" to "company-for-nesting" - this schema then has a "share_parcels" attribute (https://github.com/openc/openc-schema/blob/master/schemas/includes/company-for-nesting.json#L83) which can take an array of existing share parcels as per this schema: https://github.com/openc/openc-schema/blob/master/schemas/includes/share-parcel.json using which we should be able to record the share parcels + shareholders.
So the format will be something like:
:share_parcels =>
[ { :number_of_shares => 1234,
:shareholders => [ {:name => 'Fred Flintstone'} ],
:confidence => 42
},
{ :percentage_of_shares => 23.5,
:shareholders => [ {:name => 'Barney Rubble'},
{:name => 'Wilma Flintstone'} ]
},
]
},
In this case I think we have number of shares and percentage of shares.
Let me know if this is unclear and I can make up a better worked example.
Thank you,
Peter